Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1594_ec2_instance_key_name_is_not_an_error #1595

Conversation

nesies
Copy link

@nesies nesies commented Jun 5, 2023

SUMMARY

ec2_instance / do not raise an error if key_name is a empty string

Closes #1594

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_instance

ADDITIONAL INFORMATION

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1995aa87de65414d8e958eaafeb0544c

✔️ ansible-galaxy-importer SUCCESS in 3m 57s
✔️ build-ansible-collection SUCCESS in 13m 05s
✔️ ansible-test-splitter SUCCESS in 5m 22s
✔️ integration-amazon.aws-1 SUCCESS in 26m 05s
✔️ integration-amazon.aws-2 SUCCESS in 16m 45s
✔️ integration-amazon.aws-3 SUCCESS in 13m 12s
✔️ integration-amazon.aws-4 SUCCESS in 11m 45s
✔️ integration-amazon.aws-5 SUCCESS in 11m 50s
✔️ integration-amazon.aws-6 SUCCESS in 7m 12s
✔️ integration-amazon.aws-7 SUCCESS in 11m 48s
✔️ integration-amazon.aws-8 SUCCESS in 7m 42s
✔️ integration-amazon.aws-9 SUCCESS in 7m 00s
✔️ integration-amazon.aws-10 SUCCESS in 11m 02s
✔️ integration-amazon.aws-11 SUCCESS in 10m 23s
✔️ integration-amazon.aws-12 SUCCESS in 9m 27s
✔️ integration-amazon.aws-13 SUCCESS in 7m 34s
✔️ integration-amazon.aws-14 SUCCESS in 8m 10s
✔️ integration-amazon.aws-15 SUCCESS in 7m 19s
✔️ integration-amazon.aws-16 SUCCESS in 9m 07s
✔️ integration-amazon.aws-17 SUCCESS in 10m 33s
Skipped 27 jobs

@nesies nesies force-pushed the 1594_ec2_instance_key_name_is_not_an_error branch from a80a2c8 to 7d69003 Compare June 6, 2023 09:33
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ba1b15bc577042c9915240b21f861bc6

✔️ ansible-galaxy-importer SUCCESS in 4m 58s
✔️ build-ansible-collection SUCCESS in 12m 45s
✔️ ansible-test-splitter SUCCESS in 5m 22s
✔️ integration-amazon.aws-1 SUCCESS in 18m 55s
✔️ integration-amazon.aws-2 SUCCESS in 12m 41s
✔️ integration-amazon.aws-3 SUCCESS in 15m 10s
✔️ integration-amazon.aws-4 SUCCESS in 10m 40s
✔️ integration-amazon.aws-5 SUCCESS in 11m 00s
✔️ integration-amazon.aws-6 SUCCESS in 11m 17s
✔️ integration-amazon.aws-7 SUCCESS in 14m 03s
✔️ integration-amazon.aws-8 SUCCESS in 7m 28s
✔️ integration-amazon.aws-9 SUCCESS in 8m 58s
✔️ integration-amazon.aws-10 SUCCESS in 12m 50s
integration-amazon.aws-11 RETRY_LIMIT in 1m 34s
integration-amazon.aws-12 RETRY_LIMIT in 1m 34s
✔️ integration-amazon.aws-13 SUCCESS in 8m 58s
integration-amazon.aws-14 RETRY_LIMIT in 1m 33s
✔️ integration-amazon.aws-15 SUCCESS in 9m 50s
✔️ integration-amazon.aws-16 SUCCESS in 13m 52s
✔️ integration-amazon.aws-17 SUCCESS in 9m 56s
Skipped 27 jobs

@hakbailey
Copy link
Contributor

@nesies Thank you for submitting a PR, however the current behavior is the documented method for handling undefined variables in Ansible, therefore we don't want to use a different strategy for this module.

@hakbailey hakbailey closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ec2_instance / key_name assume not provided if empty
2 participants